[patch] Re: 2.5.3[3,4] Preemption problem

From: Robert Love (rml@tech9.net)
Date: Tue Sep 10 2002 - 14:44:38 EST


On Mon, 2002-09-09 at 17:31, Paolo Ciarrocchi wrote:

> Halting system...
> Shutting down devices
> Power down.
> note: halt[15347] exited with preempt_count 1

I cooked up a patch... does this solve the problem (no more spurious
warning on reboot)?

Patch is against 2.5.34.

        Robert Love

diff -urN linux-2.5.34/kernel/sys.c linux/kernel/sys.c
--- linux-2.5.34/kernel/sys.c Tue Sep 10 13:04:49 2002
+++ linux/kernel/sys.c Tue Sep 10 15:40:35 2002
@@ -316,7 +316,7 @@
 
         /* For safety, we require "magic" arguments. */
         if (magic1 != LINUX_REBOOT_MAGIC1 ||
- (magic2 != LINUX_REBOOT_MAGIC2 && magic2 != LINUX_REBOOT_MAGIC2A &&
+ (magic2 != LINUX_REBOOT_MAGIC2 && magic2 != LINUX_REBOOT_MAGIC2A &&
                         magic2 != LINUX_REBOOT_MAGIC2B))
                 return -EINVAL;
 
@@ -344,6 +344,7 @@
                 device_shutdown();
                 printk(KERN_EMERG "System halted.\n");
                 machine_halt();
+ unlock_kernel();
                 do_exit(0);
                 break;
 
@@ -353,6 +354,7 @@
                 device_shutdown();
                 printk(KERN_EMERG "Power down.\n");
                 machine_power_off();
+ unlock_kernel();
                 do_exit(0);
                 break;
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Sep 15 2002 - 22:00:22 EST