Re: Linux 2.4.20-pre6 tg3 compile errors

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Wed Sep 11 2002 - 08:36:46 EST


David S. Miller wrote:
> From: Jeff Garzik <jgarzik@mandrakesoft.com>
> Date: Tue, 10 Sep 2002 22:37:25 -0400
>
> Wrap this line of code inside a
>
> #if TG3_VLAN_TAG_USED
> ...line 4881 here...
> #endif
>
> Not sufficient, you need to have an "#else" clause that
> sets RX_MODE_KEEP_VLAN_TAG all the time.

So IOW what I said was correct, but Steve's patch was wrong :)

You don't need a #else clause because line 4882 sets
RX_MODE_KEEP_VLAN_TAG unconditionally, if you #ifdef out line 4881.

        Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Sep 15 2002 - 22:00:25 EST