Re: [PATCH] 2.0-2.5 bug in ip_options_compile

From: David Weinehall (tao@acc.umu.se)
Date: Fri Sep 13 2002 - 17:50:33 EST

Next message: Dave Hansen: "Re: [PATCH] per-zone^Wnode kswapd process"
Previous message: Andre Hedrick: "Re: Fix 2.5.34+swsusp data corruption on IDE"
In reply to: David S. Miller: "Re: [PATCH] 2.0-2.5 bug in ip_options_compile"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, Sep 13, 2002 at 03:13:06PM -0700, David S. Miller wrote:
> From: Jeff DeFouw <defouwj@purdue.edu>
> Date: Fri, 13 Sep 2002 17:08:38 -0500
>
> While reading about IP options, I found the IPOPT_END padding (cleaning)
> in ip_options_compile (net/ipv4/ip_options.c) was not incrementing a
> pointer. There should be an optptr++ in the for end-of-block statement
> to go along with the l--, otherwise it's just comparing the same byte
> for each l. Patch is against 2.4.19. From the kernel source browser
> this bug is also in 2.5.31, 2.2.21, and 2.0.39.
>
> Thanks a lot for spotting this, I will add this
> to my 2.4.x and 2.5.x trees and merge upstream.

Thanks. Will be in 2.0.40-rc7.

Regards: David Weinehall

-- 
 /> David Weinehall <tao@acc.umu.se> /> Northern lights wander      <\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\>  http://www.acc.umu.se/~tao/    </   Full colour fire           </
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Dave Hansen: "Re: [PATCH] per-zone^Wnode kswapd process"
Previous message: Andre Hedrick: "Re: Fix 2.5.34+swsusp data corruption on IDE"
In reply to: David S. Miller: "Re: [PATCH] 2.0-2.5 bug in ip_options_compile"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Sep 15 2002 - 22:00:35 EST