On Sat, 14 Sep 2002, Lev Makhlis wrote:
| > +#define MSEC(x) ((x) * 1000 / HZ)
| Perhaps it would be better to report the times in ticks using
| jiffies_to_clock_t(), and let the userland do further conversions?
| The macro above has an overflow problem, it creates a counter
| that wraps at 2^32 / HZ (instead of 2^32), and theoretically, the
| userland doesn't even know what the internal HZ is. The overflow
| can be avoided with something like
| #define MSEC(x) (((x) / HZ) * 1000 + ((x) % HZ) * 1000 / HZ)
| but I think it would be cleaner just to change the units to ticks,
| especially if we're moving it to a different file and procps will
| need to be changed anyway.
Thanks for pointing this out.
I'd rather not expose more ticks in /proc, so for now
I'll ask Rick to use this #define for MSEC, which does
indeed work nicely.
-- ~Randy "Linux is not a research project. Never was, never will be." -- Linus, 2002-09-02
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to firstname.lastname@example.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Sep 23 2002 - 22:00:23 EST