can we drop early_serial_setup()?

From: David Mosberger (
Date: Thu Sep 19 2002 - 23:59:19 EST

The early_serial_setup() routine was broken during the big serial
clean up that happened a while ago. I fixed this problem for ia64 by
introducing a new routine called early_register_port() (see below).
It serves the same purpose as early_serial_setup(), with the only
difference being that the argument passed to it is now a "uart_port"
structure (instead of a "serial_struct"). Russell King suggested to
get rid of early_serial_setup() alltogether, since it is broken anyhow
and serves no purpose anymore. However, as far as I can tell, there
are two places left which use this routine:


It's should be easy to convert these files to early_register_port(),
but since I can't test the platform's in question (PPC and SGI SN
machine), I'd like to know whether it's OK to drop
early_serial_setup() now. If someone wants some hints on how to do
the conversion, let me know (sample code is in 8250_hcdp.c).



int __init early_register_port (struct uart_port *port)
        if (port->line >= ARRAY_SIZE(serial8250_ports))
                return -ENODEV;

        serial8250_isa_init_ports(); /* force ISA defaults */
        serial8250_ports[port->line].port = *port;
        serial8250_ports[port->line].port.ops = &serial8250_pops;
        return 0;
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon Sep 23 2002 - 22:00:29 EST