Re: [PATCH][RESEND] Cleanup (BIN|BCD)_TO_(BCD|BIN) usage/macros

From: Jeff Garzik (
Date: Fri Sep 20 2002 - 09:56:08 EST

Tom Rini wrote:
> The other thing, is that in general people seem to expect BIN_TO_BCD(X) to
> not return a value, and just convert X. Would it be better to replace
> CONVERT_x to __x then ?

My gut feeling is that the users in the majority -- the ones that don't
return a value -- are still abnormal. Side effects on arguments are the
rare case in C, even if it is the common case here.

But to answer your question, I think s/CONVERT_x/__x/ is better than


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon Sep 23 2002 - 22:00:30 EST