Re: my review of the Device Driver Hardening Design Spec

From: Greg KH (
Date: Sat Sep 21 2002 - 17:42:35 EST

On Sat, Sep 21, 2002 at 11:52:19PM +0200, Francois Romieu wrote:
> [Cc list trimmed]
> Greg KH <> :
> [...]
> > Oh, there's lots of code:
> > A "hardened" binary kernel driver:
> >
> > (um people, why a binary? Where's the source for this?)
> In the cvs. See:

Thanks for pointing this out, I missed it.

Hm, if this is the code that the CG group is proposing for reliable
drivers, we are all in trouble. See:*checkout*/hardeneddrivers/sample_driver/src/sampledriver.h?rev=

as a very small example of what not to do :)

I'd be glad to provide concrete criticism of the other files in this
directory, if I thought people would actually change their programming
style to follow what their own spec says to do...

contains so many examples of bad style, and real bugs...

greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon Sep 23 2002 - 22:00:33 EST