Re: 2.5.38-mm2 [PATCH]

From: Dipankar Sarma (dipankar@in.ibm.com)
Date: Mon Sep 23 2002 - 12:33:40 EST

Next message: Andrew Morton: "Re: 2.5.38-mm2 [PATCH]"
Previous message: Greg KH: "Re: Oops in usb_submit_urb with US_FL_MODE_XLATE (2.4.19 and 2.4.20-pre7)"
In reply to: Andrew Morton: "Re: 2.5.38-mm2 [PATCH]"
Next in thread: Dipankar Sarma: "Re: 2.5.38-mm2 [PATCH] (dcache)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, Sep 23, 2002 at 09:28:41AM -0700, Andrew Morton wrote:
> #ifdef CONFIG_PREEMPTION
> #define rcu_read_lock() preempt_disable()
> #define rcu_read_unlock() preempt_enable()
> #else
> #define rcu_read_lock() do {} while(0)
> #define rcu_read_unlock() do {} while(0)
> #endif
>
> with
>
> #define rcu_read_lock() preempt_disable()
> #define rcu_read_unlock() preempt_enable()
>
> because preempt_disable() is a no-op on CONFIG_PREEMPT=n anyway.

This is fine. The original rcu_ltimer patch needed #ifdef CONFIG_PREEMPT,
so that it could be easily used with 2.4. With preemption in 2.5,
rcu_read_xxx() can be preempt_xxx().

Thanks

-- 
Dipankar Sarma  <dipankar@in.ibm.com> http://lse.sourceforge.net
Linux Technology Center, IBM Software Lab, Bangalore, India.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Andrew Morton: "Re: 2.5.38-mm2 [PATCH]"
Previous message: Greg KH: "Re: Oops in usb_submit_urb with US_FL_MODE_XLATE (2.4.19 and 2.4.20-pre7)"
In reply to: Andrew Morton: "Re: 2.5.38-mm2 [PATCH]"
Next in thread: Dipankar Sarma: "Re: 2.5.38-mm2 [PATCH] (dcache)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Sep 23 2002 - 22:00:39 EST