From: YOSHIFUJI Hideaki / $B5HF#1QL@(B <yoshfuji@linux-ipv6.org>
Date: Fri, 27 Sep 2002 18:12:56 +0900 (JST)
This patch has problems.
@@ -1626,24 +1635,32 @@
for (ifp=inet6_addr_lst[i]; ifp; ifp=ifp->lst_next) {
unsigned long age;
- if (ifp->flags & IFA_F_PERMANENT)
+ spin_lock(&ifp->lock);
+ if (ifp->flags & IFA_F_PERMANENT) {
+ spin_unlock(&ifp->lock);
continue;
+ }
This is completely unnecessary. Nobody modifies the
IFA_F_PERMANENT flag after the addr entry has been added
to the hash table and this runs under the addrconf hash
lock already.
Alexey will have to comment on the rest.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Sep 30 2002 - 22:00:30 EST