Re: [PATCH] ALSA update [6/10] - 2002/07/20

• Next message: Dipankar Sarma: "Re: [patch] smptimers, old BH removal, tq-cleanup, 2.5.39"
• Previous message: Andi Kleen: "Re: [PATCH] Use __attribute__((malloc)) for gcc 3.2"
• In reply to: Jaroslav Kysela: "[PATCH] ALSA update [6/10] - 2002/07/20"
• Next in thread: Jaroslav Kysela: "Re: [PATCH] ALSA update [6/10] - 2002/07/20"
• Reply: Jaroslav Kysela: "Re: [PATCH] ALSA update [6/10] - 2002/07/20"
• Reply: David S. Miller: "Re: [PATCH] ALSA update [6/10] - 2002/07/20"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, 2002-09-29 at 20:51, Jaroslav Kysela wrote:
> + sgbuf = snd_magic_cast(snd_pcm_sgbuf_t, substream->dma_private, return -EINVAL);

hummmm magic casts?? why ?

> + ptr = snd_malloc_pci_pages(sgbuf->pci, PAGE_SIZE, &addr);

what is wrong with the PCI DMA API that makes ALSA wants a private
interface/implementation ?

> EXPORT_SYMBOL(snd_wrapper_kmalloc);
> EXPORT_SYMBOL(snd_wrapper_kfree);
> +EXPORT_SYMBOL(snd_wrapper_vmalloc);
> +EXPORT_SYMBOL(snd_wrapper_vfree);

why do you need a wrapper for vfree?

• application/pgp-signature attachment: This is a digitally signed message part

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Dipankar Sarma: "Re: [patch] smptimers, old BH removal, tq-cleanup, 2.5.39"
• Previous message: Andi Kleen: "Re: [PATCH] Use __attribute__((malloc)) for gcc 3.2"
• In reply to: Jaroslav Kysela: "[PATCH] ALSA update [6/10] - 2002/07/20"
• Next in thread: Jaroslav Kysela: "Re: [PATCH] ALSA update [6/10] - 2002/07/20"
• Reply: Jaroslav Kysela: "Re: [PATCH] ALSA update [6/10] - 2002/07/20"
• Reply: David S. Miller: "Re: [PATCH] ALSA update [6/10] - 2002/07/20"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Sep 30 2002 - 22:00:42 EST