Re: [PATCH][2.5] Single linked lists for Linux, overly complicated v2

From: Daniel Phillips (phillips@arcor.de)
Date: Mon Sep 30 2002 - 14:37:53 EST

Next message: Andrew Morton: "Re: [BENCHMARK] 2.5.39-mm1"
Previous message: Bill Davidsen: "Re: v2.6 vs v3.0"
In reply to: Zach Brown: "Re: [PATCH][2.5] Single linked lists for Linux, overly complicated v2"
Next in thread: Zach Brown: "Re: [PATCH][2.5] Single linked lists for Linux, overly complicated v2"
Reply: Zach Brown: "Re: [PATCH][2.5] Single linked lists for Linux, overly complicated v2"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Friday 27 September 2002 02:57, Zach Brown wrote:
> #define tslist_add(_head, _elem) \
> do { \
> BUG_ON(tslist_on_list(_head, _elem)); \
> (_elem)->_slist_next = (_head); \
> (_head) = (_elem); \
> } while(0)

This evaluates _head and _elem twice each, or three times if you count
the BUG_ON.

Smaller point: why bother obfuscating the parameter names? You will
need to do that for locals in macros but parameters should cause no
name conflicts.

-- 
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Andrew Morton: "Re: [BENCHMARK] 2.5.39-mm1"
Previous message: Bill Davidsen: "Re: v2.6 vs v3.0"
In reply to: Zach Brown: "Re: [PATCH][2.5] Single linked lists for Linux, overly complicated v2"
Next in thread: Zach Brown: "Re: [PATCH][2.5] Single linked lists for Linux, overly complicated v2"
Reply: Zach Brown: "Re: [PATCH][2.5] Single linked lists for Linux, overly complicated v2"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Sep 30 2002 - 22:00:47 EST