Re: [Evms-devel] Re: [PATCH] EVMS core 2/4: evms.h

From: Christoph Hellwig (hch@infradead.org)
Date: Thu Oct 03 2002 - 10:14:05 EST


On Thu, Oct 03, 2002 at 11:10:14PM +0800, Michael Clark wrote:
>
> >>+#define DEV_PATH "/dev"
> >>+#define EVMS_DIR_NAME "evms"
> >>+#define EVMS_DEV_NAME "block_device"
> >>+#define EVMS_DEV_NODE_PATH DEV_PATH "/" EVMS_DIR_NAME "/"
> >>+#define EVMS_DEVICE_NAME DEV_PATH "/" EVMS_DIR_NAME "/" EVMS_DEV_NAME
> >
> >
> > The kernel doesn't know about device names at all.
>
> It does for specifying root devices and for devfs.A

root device should be in do_mount.c and not in obscure headers.
devfs doesn'T need hardcoded "/dev" prefixes, and it's better to not
add defines for the strings in devfs so that crap doesn't get spread
over the code but is localized to the existing devfs damage
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:39 EST