Re: [PATCH] cli()/sti() fix for drivers/net/depca.c

From: Francois Romieu (romieu@cogenit.fr)
Date: Thu Oct 03 2002 - 11:40:41 EST

Next message: Matthew Wilcox: "Re: [PATCH] Start of cleaning up socket ioctls"
Previous message: Hell.Surfers@cwctv.net: "RE:2.5.40"
In reply to: Denis Vlasenko: "Re: [PATCH] cli()/sti() fix for drivers/net/depca.c"
Next in thread: Denis Vlasenko: "Re: [PATCH] cli()/sti() fix for drivers/net/depca.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> :
[...]
> > depca_rx() looks strange:
> > buf = skb_put(skb, len);
> > [...]
> > netif_rx(skb);
> > [...]
> > if (buf[0] & ...)
>
> I'd say this network stuff is a bit cryptic for untrained eye :-)
> What's strange with that code?

One shouldn't assume the buffer is available once it was passed to
netif_rx().

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Matthew Wilcox: "Re: [PATCH] Start of cleaning up socket ioctls"
Previous message: Hell.Surfers@cwctv.net: "RE:2.5.40"
In reply to: Denis Vlasenko: "Re: [PATCH] cli()/sti() fix for drivers/net/depca.c"
Next in thread: Denis Vlasenko: "Re: [PATCH] cli()/sti() fix for drivers/net/depca.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:40 EST