Re: bcopy()

From: Linus Torvalds (torvalds@transmeta.com)
Date: Mon Oct 07 2002 - 13:08:19 EST


On Mon, 7 Oct 2002, Mike Galbraith wrote:
> >
> >XFS seems to be a big user of bcopy, though..
>
> Does it matter from the cleanliness side? (1->N users)

It does.

I will not apply a patch that removes bcopy() in the name of
"cleanliness", if it then results in a number of modules just adding their
own

        #define bcopy(a,b,c) memcpy(b,a,c)

because then the whole cleanup would be pointless - it would just make
some modules even uglier than they were before.

So I'd much rather see the XFS etc code moved away from bcopy() first,
because that's the _real_ cleanup. The library code isn't all that ugly in
comparison.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:59 EST