Re: [PATCH] Device-mapper submission 4/7

From: Joe Thornber (joe@fib011235813.fsnet.co.uk)
Date: Tue Oct 15 2002 - 16:46:51 EST


On Tue, Oct 15, 2002 at 12:19:28PM -0600, Andreas Dilger wrote:
> On Oct 15, 2002 18:46 +0100, Joe Thornber wrote:
> > [Device-mapper]
> > The linear target maps a contigous range of logical sectors onto an
> > range of physical sectors.
> >
> > +struct linear_c {
> > + long delta; /* FIXME: we need a signed offset type */
> > + long start; /* For display only */
> > + struct dm_dev *dev;
> > +};
>
> Should those not be sector_t type fields?

'start' certainly should be, it looks like 'delta' will have to split
into a sign and a sector_t. Maybe I should read my own FIXMEs
sometime rather than having you do it for me :)

   Joe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Oct 15 2002 - 22:00:57 EST