Re: [PATCH] ipv4: make arp seq_file show method only produce one record per call

From: Arnaldo Carvalho de Melo (acme@conectiva.com.br)
Date: Wed Oct 16 2002 - 21:10:28 EST


Em Wed, Oct 16, 2002 at 11:00:01PM -0300, Arnaldo C. Melo escreveu:
> Em Wed, Oct 16, 2002 at 06:28:14PM -0700, David S. Miller escreveu:
> > From: Neil Brown <neilb@cse.unsw.edu.au>
> > Date: Thu, 17 Oct 2002 11:30:43 +1000
> >
> > I use seq->private for private state for /proc/fs/nfs/exports.
> > It works nicely.
> > You need to define an 'open' the sets it up, and a 'release' to
> > tear it down, rather than doing it in start/stop.
> > See fs/nfsd/fnsctl.c:exports_open
> >
> > Hmmm, Arnaldo? :-)
>
> I know that it works :-) I just refrained from using it because it is
> not the designed purpose for this field, as per what the author stated to me,
> so I didn't wanted to use in a way that could change under my feet in the
> future when Al decided to do some change in seq_file.
>
> But if Al changes his mind and state that this is valid use, great,
> I'll happily use it.
>
> See my other post with Al's comments.

Ok, /me knocks his head on the wall, rereading I think that it is OK, just the
_pointer_ can't change, oh well, duh, back to work.

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Oct 23 2002 - 22:00:31 EST