Re: [PATCH] 2.5.43 : drivers/block/xd.c

From: Daniel Egger (degger@fhm.edu)
Date: Sun Oct 20 2002 - 18:33:17 EST


Am Sam, 2002-10-19 um 02.58 schrieb Frank Davis:

> Hello all,
> The following fixes a 'used but not declared' compile error. Please review
> for inclusion.

The "standard" way of achieving the same would be to assign the variable
to itself. In your fragment the compiler will initialise the variable to
zero which will cost at least one instruction and thus "bloat" the code,
it'll also be slower due to an additional instruction and may schedule
worse. Not that it mattered much in this case but if you can save a byte
or two... :)
 

-- 
Servus,
       Daniel


- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Oct 23 2002 - 22:00:52 EST