Re: [PATCH] 2.4: variable HZ

From: Neil Conway (nconway.list@ukaea.org.uk)
Date: Mon Oct 21 2002 - 03:15:32 EST


Robert Love wrote:
> OK, sure, but why specify a power-of-two HZ? There is absolutely no
> reason to, at least on x86.

Totally agree. However, I wasn't restricting it to powers of two. You
just happened to have mentioned 512 (wrt. RedHat).

> Want 512? 500 will do just as well and has the benefit of (a) being a
> multiple of the previous HZ and (b) evenly dividing into our concept of
> time.

512 ~= 500. 150 !~= 100. Would someone want to use 150? Maybe...

Anyway, it's no big deal if you prefer to leave your patch as-is.
However, if you do, then you need to at least add a comment to the code
and modify the Configure.help to make it clear that only integer
multiples work properly. In fact, you could just make the HZ Config
value be a "speed-up ratio" which would make various bits of the patch
cleaner.

Neil
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Oct 23 2002 - 22:00:52 EST