On Mon, Oct 21, 2002 at 11:11:51AM -0600, Khalid Aziz wrote:
I like the concept.
Few comments:
Touching all defconfigs is not good. Try to limit the impact of the patch.
People just have to press return two more times when running oldconfig.
> diff -urN --exclude-from=/linux/diff_exclude_file linux-2.5.44/kernel/Makefile linux-2.5.44-ikconfig/kernel/Makefile
> include $(TOPDIR)/Rules.make
> +
> +$(obj)/ikconfig.h: $(TOPDIR)/scripts/mkconfigs $(TOPDIR)/.config $(TOPDIR)/Makefile
> + chmod 755 $(TOPDIR)/scripts/mkconfigs
> + $(TOPDIR)/scripts/mkconfigs $(TOPDIR)/.config $(TOPDIR)/Makefile > $(obj)/ikconfig.h
> +
> +$(obj)/configs.o: $(obj)/ikconfig.h $(obj)/configs.c \
> + $(TOPDIR)/include/linux/version.h \
> + $(TOPDIR)/include/linux/compile.h
Please avoid using $(TOPDIR)
The build is running from root of the kernel tree anyway, so it is nor required.
Use $(CONFIG_SHELL) when executing scripts, to avoid the necessity to have the executable
bit set.
Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Oct 23 2002 - 22:00:55 EST