On Tue, 22 Oct 2002, Christoph Hellwig wrote:
|>On Mon, Oct 21, 2002 at 03:06:59PM -0700, Piet Delaney wrote:
|>> > Shouldn't much of this be static? again volatile is seldomly a good idea.
|>>
|>> I suppose with 'bio_complete' being an int changing it's value is
|>> atomic as long as it's treated a a volatile.Using a spinlock might
|>> be cleaner.
|>
|>an atomic_t or set_bit/test_bit/etc is used to be atomic in the kernel
|>if you don't want a lock. And in this case a lock looks like overkill.
All of the volatile/atomic, C99, typedef, data format, return format,
u64/32/16/etc, are all addressed and fixed in the latest patches. The
dump_bp() is removed for now, to be considered later if/when it makes
sense.
We'd want to keep the ioctl() interface, given the number of programs
using it across multiple platforms (and is being considered for
multiple OSes). DUMP_MAJOR has changed to CRASH_DUMP_MAJOR and is
now standard in major.h. Finally, the MAINTAINERS and Config.help
files are updated.
We're correcting a few more issues with the mem_map[], page_is_ram(),
etc., usage, but those shouldn't take long.
If anyone needs a preliminary patch this morning, let me know.
--Matt
P.S. Pete, we can go through the dump_bp() stuff on the mailing list.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Oct 23 2002 - 22:00:59 EST