Re: [PATCH 2/2] 2.5.46 AIO support for raw/O_DIRECT

From: Andrew Morton (akpm@digeo.com)
Date: Tue Nov 05 2002 - 20:17:32 EST


Badari Pulavarty wrote:
>
> Hi,
>
> This is (part 2/2) 2.5.46 patch to support AIO for raw/O_DIRECT.
>
> This patch adds AIO support for DIO code path. This patch also
> has a work around for calling set_page_dirty() from interrupt
> context problem.
>
> Andrew, could you please check to see if I did "set_page_dirty()"
> hack (you suggested) correctly (in the right place) ?
>

Looks like it. It's such a hack, I want to hide ;)

Sigh. I think I'd prefer to just go and make ->page_lock
and ->private_lock irq-safe.

Or not proceed with this patch at all. If this is to be the
only code which wishes to perform page list motion at interrupt
time, perhaps it's not justifiable?

I really don't have a feeling for how valuable this is, nor
do I know whether there will be other code which wants to
perform page list manipulation at interrupt time.

In fact I also don't know where the whole AIO thing sits at
present. Is it all done and finished? Is there more to come,
and if so, what??
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 07 2002 - 22:00:40 EST