Re: [PATCH] pnp.h changes - 2.5.46 (4/6)

From: Greg KH (greg@kroah.com)
Date: Thu Nov 07 2002 - 01:01:02 EST


On Wed, Nov 06, 2002 at 09:06:39PM +0000, Adam Belay wrote:
>
> +static inline void *pnp_get_drvdata (struct pnp_dev *pdev)
> +{
> + return pdev->dev.driver_data;
> +}
> +
> +static inline void pnp_set_drvdata (struct pnp_dev *pdev, void *data)
> +{
> + pdev->dev.driver_data = data;
> +}
> +
> +static inline void *pnp_get_protodata (struct pnp_dev *pdev)
> +{
> + return pdev->protocol_data;
> +}
> +
> +static inline void pnp_set_protodata (struct pnp_dev *pdev, void *data)
> +{
> + pdev->protocol_data = data;
> +}

Any reason for not just using dev_get_drvdata() and dev_set_drvdata() in
the drivers? Or at the least, use them within these functions, that's
what they are there for :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 07 2002 - 22:00:47 EST