Re: [PATCH] Update of tms380tr / tmsisa for 2.5.45

From: Jeff Garzik (jgarzik@pobox.com)
Date: Thu Nov 07 2002 - 13:25:05 EST


Jochen Friedrich wrote:
> - if (tms_isa_probe(dev))
> + if (!tms_isa_probe(dev))
> {
> - unregister_netdev(dev);
> - kfree(dev);
> - }
> - else
> num++;
> + dev = init_trdev(NULL, 0);
> + if (!dev)
> + return (0);

you still haven't address my comments from the last time you posted
this: twice you add code like the above that bails out, without
cleaning up any prior instances of this network card. For example if
card #2 fails to register but cards #0 and #1 are registered and probed
successfully, you have problems...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 07 2002 - 22:00:49 EST