On Wed, Nov 06, 2002 at 10:01:02PM -0800, Greg KH wrote:
> On Wed, Nov 06, 2002 at 09:06:39PM +0000, Adam Belay wrote:
> >
> > +static inline void *pnp_get_drvdata (struct pnp_dev *pdev)
> > +{
> > + return pdev->dev.driver_data;
> > +}
> > +
> > +static inline void pnp_set_drvdata (struct pnp_dev *pdev, void *data)
> > +{
> > + pdev->dev.driver_data = data;
> > +}
> > +
> > +static inline void *pnp_get_protodata (struct pnp_dev *pdev)
> > +{
> > + return pdev->protocol_data;
> > +}
> > +
> > +static inline void pnp_set_protodata (struct pnp_dev *pdev, void *data)
> > +{
> > + pdev->protocol_data = data;
> > +}
>
> Any reason for not just using dev_get_drvdata() and dev_set_drvdata() in
> the drivers? Or at the least, use them within these functions, that's
> what they are there for :)
>
> thanks,
>
> greg k-h
Sure, here's a patch. I think I'll use them within these functions.
Thanks,
Adam
Is this ok?
diff -ur a/include/linux/pnp.h b/include/linux/pnp.h
--- a/include/linux/pnp.h Wed Nov 6 17:52:11 2002
+++ b/include/linux/pnp.h Thu Nov 7 19:19:07 2002
@@ -75,12 +75,12 @@
static inline void *pnp_get_drvdata (struct pnp_dev *pdev)
{
- return pdev->dev.driver_data;
+ return dev_get_drvdata(&pdev->dev);
}
static inline void pnp_set_drvdata (struct pnp_dev *pdev, void *data)
{
- pdev->dev.driver_data = data;
+ dev_set_drvdata(&pdev->dev, data);
}
static inline void *pnp_get_protodata (struct pnp_dev *pdev)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Nov 07 2002 - 22:00:50 EST