[PATCH] memory leak in ndisc_router_discovery

• Next message: Michel Eyckmans (MCE): "2.5.46 scsi (aic7xxx?) reboot failure & kernel panic"
• Previous message: David Woodhouse: "RFC: mmap(PROT_READ, MAP_SHARED) fails if !writepage."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Alexey & Dave,

There is a bug in router advertisement handling code, where the reference
(and memory) to the inet6_dev pointer can get leaked. Following is the patch
to fix it (patch against 2.5.46) :

thanks,

- KK

diff -ruN linux.org/net/ipv6/ndisc.c linux/net/ipv6/ndisc.c
--- linux.org/net/ipv6/ndisc.c Fri Nov 7 10:02:11 2002
+++ linux/net/ipv6/ndisc.c Fri Nov 8 14:37:27 2002
@@ -871,6 +871,7 @@
         }
 
         if (!ndisc_parse_options(opt, optlen, &ndopts)) {
+ in6_dev_put(in6_dev);
                 if (net_ratelimit())
                         ND_PRINTK2(KERN_WARNING
                                    "ICMP6 RA: invalid ND option, ignored.\n");
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Michel Eyckmans (MCE): "2.5.46 scsi (aic7xxx?) reboot failure & kernel panic"
• Previous message: David Woodhouse: "RFC: mmap(PROT_READ, MAP_SHARED) fails if !writepage."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:16 EST