Re: [PATCH][2.5] do_nmi needs irq_enter/irq_exit lovin...

• Next message: Greg KH: "Re: [parisc-linux] Untested port of parisc_device to generic device interface"
• Previous message: Paul Mackerras: "[PATCH] Update adbhid.c driver"
• In reply to: Zwane Mwaikambo: "[PATCH][2.5] do_nmi needs irq_enter/irq_exit lovin..."
• Next in thread: Zwane Mwaikambo: "Re: [PATCH][2.5] do_nmi needs irq_enter/irq_exit lovin..."
• Reply: Zwane Mwaikambo: "Re: [PATCH][2.5] do_nmi needs irq_enter/irq_exit lovin..."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, 9 Nov 2002, Zwane Mwaikambo wrote:
>
> You don't even want to see the oops ;) But there is some more work
> required before this will all work. I'll require your comments on a few
> more incoming patches.

I think it would be cleaner to have the smp_processor_id() within the
irq_enter/exit() pair, even if the thing should be safe the way you do it
thanks to local interrupts being disabled..

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Greg KH: "Re: [parisc-linux] Untested port of parisc_device to generic device interface"
• Previous message: Paul Mackerras: "[PATCH] Update adbhid.c driver"
• In reply to: Zwane Mwaikambo: "[PATCH][2.5] do_nmi needs irq_enter/irq_exit lovin..."
• Next in thread: Zwane Mwaikambo: "Re: [PATCH][2.5] do_nmi needs irq_enter/irq_exit lovin..."
• Reply: Zwane Mwaikambo: "Re: [PATCH][2.5] do_nmi needs irq_enter/irq_exit lovin..."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:17 EST