Re: [PATCH] NCR53C9x ESP: C99 designated initializers

From: Alan Cox (alan@lxorguk.ukuu.org.uk)
Date: Sun Nov 10 2002 - 09:38:00 EST


On Sun, 2002-11-10 at 10:27, Geert Uytterhoeven wrote:
ut soft reset.
> */
> -int esp_reset(Scsi_Cmnd *SCptr, unsigned int how)
> +int esp_reset(Scsi_Cmnd *SCptr)
> {
> struct NCR_ESP *esp = (struct NCR_ESP *) SCptr->host->hostdata;
>
> (void) esp_do_resetbus(esp, esp->eregs);
> - return SCSI_RESET_PENDING;
> + wait_event(esp->reset_queue, (esp->resetting_bus == 0));
> +
> + return SUCCESS;
> }

Reset is called with the lock held surely. How can the wait_event be
right ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:19 EST