Re: BOGUS: megaraid changes

From: Linus Torvalds (torvalds@transmeta.com)
Date: Sun Nov 10 2002 - 13:43:17 EST


On Sun, 10 Nov 2002, J.E.J. Bottomley wrote:
>
> How about this? It doesn't panic, just refuses to attach the driver (although
> this will still eventually cause a panic if your root fs is on it).

I think this is worse than the current state of art. We don't want to
screw with users who can't do anything about it, which is 99.9% of them.
TESTING is about as important as anything else, and inconveniencing users
is BAD BAD BAD.

Right now drivers with old EH handling will warn at compile time (except
when people explicitly disable it, like in megaraid, which is in the
process of getting fixed anyway). That's a lot better than irritating
users. Especially since this printk() will possibly have scrolled off the
screen by the time the "cannot load root" happens.

I've said this before, I'll say it again: anything that breaks _working_
is BAD. Don't do it. Don't make up new ways to screw with people who want
to test. Don't add features that have _no_ meaning except to irritate
people.

The compile-time warning is _plenty_ good enough.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:20 EST