Re: [PATCH][2.5] Remove BUG in cpu_up

From: Rusty Russell (rusty@rustcorp.com.au)
Date: Wed Nov 13 2002 - 04:33:11 EST

Next message: Rusty Russell: "Re: [PATCH][2.5] smp_init 'CPUS done' looks strange"
Previous message: Xavier Bestel: "Re: repeatable IDE errors when using SMART"
In reply to: Zwane Mwaikambo: "[PATCH][2.5] Remove BUG in cpu_up"
Next in thread: Zwane Mwaikambo: "Re: [PATCH][2.5] Remove BUG in cpu_up"
Reply: Zwane Mwaikambo: "Re: [PATCH][2.5] Remove BUG in cpu_up"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

In message <Pine.LNX.4.44.0211122236270.24523-100000@montezuma.mastecende.com>
you write:
> ret = __cpu_up(cpu);
> if (ret != 0)
> goto out_notify;
> - if (!cpu_online(cpu))
> - BUG();
> +
> + if (!cpu_online(cpu)) {
> + ret = -EIO;
> + goto out_notify;
> + }

Err, no. If __cpu_up(cpu) succeeded, that means the cpu should bloody
well be online!

Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Rusty Russell: "Re: [PATCH][2.5] smp_init 'CPUS done' looks strange"
Previous message: Xavier Bestel: "Re: repeatable IDE errors when using SMART"
In reply to: Zwane Mwaikambo: "[PATCH][2.5] Remove BUG in cpu_up"
Next in thread: Zwane Mwaikambo: "Re: [PATCH][2.5] Remove BUG in cpu_up"
Reply: Zwane Mwaikambo: "Re: [PATCH][2.5] Remove BUG in cpu_up"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:28 EST