Re: PC-9800 patch for 2.5.47-ac4: not merged yet (14/15) serial

From: Andrey Panin (pazke@orbita1.ru)
Date: Fri Nov 15 2002 - 10:04:02 EST


On Птн, Ноя 15, 2002 at 10:35:18 +0900, Osamu Tomita wrote:
> Andrey Panin wrote:
> >
> > On ????????, ??????????15, 2002 at 10:06:46 +0900, Osamu Tomita wrote:
> > > This is for serial port and onboard modem support.
> >
> > > @@ -376,7 +378,12 @@
> > > ((port->min == 0x2f8) ||
> > > (port->min == 0x3f8) ||
> > > (port->min == 0x2e8) ||
> > > +#ifndef CONFIG_PC9800
> > > (port->min == 0x3e8)))
> > > +#else
> > > + (port->min == 0x3e8) ||
> > > + (port->min == 0x8b0)))
> > > +#endif
> > > return 0;
> > > }
> >
> > Why 0x8b0 should be added here ?
> > Is it one of default iobase value for C-bus PNP modems ?
> Yes. C-bus PNP modems use this default value. And old modem
> card is hard wired to this iobase.

Ok. But IMHO this way is better (check order doesn't matter here):

                        ((port->min == 0x2f8) ||
                         (port->min == 0x3f8) ||
                         (port->min == 0x2e8) ||
                         (port->min == 0x3e8) ||
#ifdef CONFIG_PC9800
                         (port->min == 0x8b0) ||
#endif

                         (port->min == 0x3e8)))
                              return 0;
        }

-- 
Andrey Panin            | Embedded systems software developer
pazke@orbita1.ru        | PGP key: wwwkeys.eu.pgp.net


- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:38 EST