A minor bug in nonfatal mcheck code. Non fatal machine check won't find any MCE faults in CONFIG_SMP and num_online_cpus==1 case, as mce_checkregs() will not be called at all. Attached patch should fix this.
Thanks,
-Venkatesh
--- linux-2.5.47/arch/i386/kernel/cpu/mcheck/non-fatal.c.org Wed Nov 13 13:17:57 2002
+++ linux-2.5.47/arch/i386/kernel/cpu/mcheck/non-fatal.c Wed Nov 13 13:24:45 2002
@@ -49,7 +49,6 @@
static void do_mce_timer(void *data)
{
- mce_checkregs (NULL);
smp_call_function (mce_checkregs, NULL, 1, 1);
}
@@ -57,11 +56,10 @@
static void mce_timerfunc (unsigned long data)
{
+ mce_checkregs (NULL);
#ifdef CONFIG_SMP
if (num_online_cpus() > 1)
schedule_work (&mce_work);
-#else
- mce_checkregs (NULL);
#endif
mce_timer.expires = jiffies + MCE_RATE;
add_timer (&mce_timer);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:38 EST