On Sun, 17 Nov 2002, Christoph Hellwig wrote:
>
> Make them take an inode instead of a file, this way we don't need
> to derefence struct dentry in fs.h and with a few more steps we can
> get rid of dcache.h in fs.h
This is the point where I say "NO!"
If we're making code uglier because we want to include fewer files, we're
doing something WRONG!
It's a lot more important to have readable code than it is to try to avoid
a file include. And this patch makes code less readable, just look at it.
Also, I'm going to stop applying the header file cleanups altogether
unless the people who send them to me check that things compile afterwards
a lot better.
Arnaldo has been helping a lot in fixing stuff up after the cleanups,
thanks go to him. The last net.h/fs.h cleanup broke pcm_native.c, for
example.
Cleanups are only good if they make things BETTER. Making things worse is
not a good thing.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:19 EST