Re: [PATCH] mii module broken under new scheme

From: Matt Reppert (arashi@arashi.yi.org)
Date: Tue Nov 19 2002 - 13:15:21 EST


On Tue, 19 Nov 2002 12:51:44 -0500
Jeff Garzik <jgarzik@pobox.com> wrote:

> Matt Reppert wrote:
>
> > drivers/net/mii.c doesn't export module init/cleanup functions. That
> > means it
> > can't be loaded under the new module scheme. This patch adds do-nothing
> > functions for it, which allows it to load. (8139too depends on mii, so
> > without this I don't have network.)
>
> ahhh! I was wondering what was up, but since I was busy with other
> things I just compiled it into the kernel and continued on my way.
>
> That's a bug in the new module loader.

Not so sure I agree ... recompiled the kernel with debugging output in
module.c and when I try to insert mii.o without above patch it complains
"Module has no name!" and returns -ENOEXEC from the syscall. I think
naming mii.o would be a good idea. This may not be the best way to do
it, but it works. (Granted, I'm not terribly familiar with all the
modules code changes yet, but ... ) Having anonymous output in lsmod
would be somewhat confusing :) ("Well, whatever it is, 8139too needs
it, don't touch it!")

Just noticed above patch is -p0. Whoops.

Matt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:28 EST