UHCI halts endpoint on control stalls: seems wrong

From: Luca Barbieri (ldb@ldb.ods.org)
Date: Sun Nov 24 2002 - 18:43:58 EST


Some time ago I reported some USB problems consisting of getting EPIPEs
when trying to read strings with lsusb.

I have done some more investigation and I think I solved the problem: I
get EPIPEs because the control endpoint is stalled due to a failure and
the halt is never cleared.

However drivers/usb/core/message.c contains the following paragraph:
"Note that control and isochronous endpoints don't halt, although
control endpoints report "protocol stall" (for unsupported requests)
using the same status code used to report a true stall."

Based on this, I tried to remove the call to usb_endpoint_halt in
uhci_result_control, and everything is now working.

Is this modification correct?



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Nov 30 2002 - 22:00:10 EST