Re: [PATCH] README change

From: Thomas Molina (tmolina@copper.net)
Date: Wed Nov 27 2002 - 22:26:27 EST


Enclosed is a second version, incorporating your suggestions.

On Wed, 27 Nov 2002, Barry K. Nathan wrote:

> Again, s/compiler/library/ (i.e., undo your change, it was right the
> first time)
> > + happens to be.

Reverted. I did change the word area to directory, which is all I
originally intended anyway.

> Can the kernel still freeze during printk if it was compiled for the
> wrong CPU type, or has that been fixed? (I haven't followed that closely
> enough.)

The actual point I wanted to make is in the new version.

> Not a criticism of your patch, but something I just noticed now -- feel
> free to ignore this: that comma after "(egcs-1.1.2)" seems awkward to me.

I removed the comma.

> > - - In order to boot your new kernel, you'll need to copy the kernel
> > + - In order to boot your new kernel you'll need to copy the kernel
>
> Conversely, this is better with the comma (IMO).

I ended up with dueling style guides on this point. I reverted to the
original, which had the comma included.

> Something seems wrong to me about this sentence. The easiest potential
> fix I can think of is s/contains/describes/, but that might not be a
> 100% fix. My problem with this sentence is that it seems to be saying
> the file:
> + "contains a suggested format for bug reports"
> + "contains...what information is most helpful to developers"

I took your suggestion. I believe the new version is shorter and clearer.

> > - them to me (torvalds@transmeta.com), and possibly to any other
> > + them to the linux-kernel mailing list and possibly to any other
>
> Should this mention the mailing list's e-mail address?

Yes. I wanted to change people from sending to Linus and have them send
to a more appropriate place.

> > + useful especially for SCSI and networking problems
>
> You (accidentally?) removed the period.

Yes. I put it back.

> > - sense). If the problem is new, tell me so, and if the problem is
> > - old, please try to tell me when you first noticed it.
> > + sense). If the problem is new, say so, and if the problem is
> > + old, please try to explain when you first noticed it.
>
> Perhaps s/explain/tell us/ ?

OK.

--- README.orig 2002-11-27 16:10:48.000000000 -0600
+++ README 2002-11-27 20:55:08.000000000 -0600
@@ -40,8 +40,9 @@
    these typically contain kernel-specific installation notes for some
    drivers for example. See ./Documentation/00-INDEX for a list of what
    is contained in each file. Please read the Changes file, as it
- contains information about the problems, which may result by upgrading
- your kernel.
+ contains information about the version of software and utilities
+ required to run 2.5 kernels as well as any "Gotchas" that could be
+ encountered.
 
  - The Documentation/DocBook/ subdirectory contains several guides for
    kernel developers and users. These guides can be rendered in a
@@ -55,11 +56,15 @@
    directory where you have permissions (eg. your home directory) and
    unpack it:
 
- gzip -cd linux-2.5.XX.tar.gz | tar xvf -
+ tar xvzf linux-2.5.XX.tar.gz
+
+or
+
+ tar xvjf linux-2.5.XX.tar.bz2
 
    Replace "XX" with the version number of the latest kernel.
 
- Do NOT use the /usr/src/linux area! This area has a (usually
+ Do NOT use the /usr/src/linux directory! It has a (usually
    incomplete) set of kernel headers that are used by the library header
    files. They should match the library, and not get messed up by
    whatever the kernel-du-jour happens to be.
@@ -84,11 +89,15 @@
    process. It determines the current kernel version and applies any
    patches found.
 
- linux/scripts/patch-kernel linux
+ use: patch-kernel [ sourcedir [ patchdir [ stopversion ] [ -acxx ] ] ]
+
+ The source directory defaults to /usr/src/linux, and the patch
+ directory defaults to the current directory.
+
 
- The first argument in the command above is the location of the
- kernel source. Patches are applied from the current directory, but
- an alternative directory can be specified as the second argument.
+ The first argument is the location of the kernel source. Patches
+ are applied from the current directory, but an alternative directory
+ can be specified as the second argument.
 
  - Make sure you have no stale .o files and dependencies lying around:
 
@@ -131,9 +140,10 @@
         - having unnecessary drivers will make the kernel bigger, and can
           under some circumstances lead to problems: probing for a
           nonexistent controller card may confuse your other controllers
- - compiling the kernel with "Processor type" set higher than 386
- will result in a kernel that does NOT work on a 386. The
- kernel will detect this on bootup, and give up.
+ - compiling the kernel with an incorrect "Processor type" will
+ result in a kernel that does NOT work. A kernel compiled for
+ i386 will work on later x86 processors, but the reverse is not
+ true.
         - A kernel with math-emulation compiled in will still use the
           coprocessor if one is present: the math emulation will just
           never get used in that case. The kernel will be slightly larger,
@@ -146,15 +156,22 @@
           should probably answer 'n' to the questions for
           "development", "experimental", or "debugging" features.
 
- - Check the top Makefile for further site-dependent configuration
- (default SVGA mode etc).
+ - Check the top Makefile for further site-dependent configuration
+ information such as host compiler or cross-platform information.
 
- - Finally, do a "make dep" to set up all the dependencies correctly.
+ - A "make dep" command was previously required at this point, but is
+ no longer necessary.
 
 COMPILING the kernel:
 
+ The steps for compiling the kernel are:
+ make bzImage
+ make modules
+ make modules_install
+ make install
+
  - Make sure you have gcc 2.95.3 available.
- gcc 2.91.66 (egcs-1.1.2), and gcc 2.7.2.3 are known to miscompile
+ gcc 2.91.66 (egcs-1.1.2) and gcc 2.7.2.3 are known to miscompile
    some parts of the kernel, and are *no longer supported*.
    Also remember to upgrade your binutils package (for as/ld/nm and company)
    if necessary. For more information, refer to ./Documentation/Changes.
@@ -163,12 +180,11 @@
 
  - Do a "make bzImage" to create a compressed kernel image. If you want
    to make a boot disk (without root filesystem or LILO), insert a floppy
- in your A: drive, and do a "make bzdisk". It is also possible to do
- "make install" if you have lilo installed to suit the kernel makefiles,
- but you may want to check your particular lilo setup first.
+ in your A: drive, and do a "make bzdisk".
 
- To do the actual install you have to be root, but none of the normal
- build should require that. Don't take the name of root in vain.
+ To do the make modules_install and make install you have to be root,
+ but none of the other build should require that.
+ Don't take the name of root in vain.
 
  - In the unlikely event that your system cannot boot bzImage kernels you
    can still compile your kernel as zImage. However, since zImage support
@@ -192,7 +208,9 @@
 
  - In order to boot your new kernel, you'll need to copy the kernel
    image (found in .../linux/arch/i386/boot/bzImage after compilation)
- to the place where your regular bootable kernel is found.
+ to the place where your regular bootable kernel is found. The
+ "make install" step will do this for you as well as changing
+ the lilo or grub configuration files.
 
    For some, this is on a floppy disk, in which case you can copy the
    kernel bzImage file to /dev/fd0 to make a bootable floppy.
@@ -213,6 +231,10 @@
    After reinstalling LILO, you should be all set. Shutdown the system,
    reboot, and enjoy!
 
+ The other popular boot manager is grub. If you use this boot
+ manager, no additional actions are required beyond changing the
+ /boot/grub/grub.conf configuration file.
+
    If you ever need to change the default root device, video mode,
    ramdisk size, etc. in the kernel image, use the 'rdev' program (or
    alternatively the LILO boot options when appropriate). No need to
@@ -222,19 +244,23 @@
 
 IF SOMETHING GOES WRONG:
 
+ - Please read the file REPORTING-BUGS before forwarding any reports
+ of suspected kernel problems to maintainers or mailing lists. It
+ describes a suggested format and content for bug reports.
+
  - If you have problems that seem to be due to kernel bugs, please check
    the file MAINTAINERS to see if there is a particular person associated
    with the part of the kernel that you are having trouble with. If there
    isn't anyone listed there, then the second best thing is to mail
- them to me (torvalds@transmeta.com), and possibly to any other
- relevant mailing-list or to the newsgroup. The mailing-lists are
- useful especially for SCSI and networking problems, as I can't test
- either of those personally anyway.
+ them to the linux-kernel mailing list (linux-kernel@vger.kernel.org)
+ and possibly to any other relevant mailing-list or to the newsgroup.
+ The mailing-lists are useful, especially for SCSI and networking
+ problems.
 
  - In all bug-reports, *please* tell what kernel you are talking about,
    how to duplicate the problem, and what your setup is (use your common
- sense). If the problem is new, tell me so, and if the problem is
- old, please try to tell me when you first noticed it.
+ sense). If the problem is new, say so, and if the problem is
+ old, please try to tell us when you first noticed it.
 
  - If the bug results in a message like
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Nov 30 2002 - 22:00:19 EST