Re: [PATCH 1/3] High-res-timers part 1 (core) take 20

From: george anzinger (george@mvista.com)
Date: Mon Dec 09 2002 - 02:03:13 EST

Arjan van de Ven wrote:
>
> On Sun, 2002-12-08 at 08:46, george anzinger wrote:
>
> > +/*
> > + * Here is an SMP helping macro...
> > + */
> > +#ifdef CONFIG_SMP
> > +#define IF_SMP(a) a
> > +#else
> > +#define IF_SMP(a)
> > +#endif
>
> ehmmmmm personally I would consider any need of this ugly and evil
>
> > + IF_SMP(if (old_base && (new_base != old_base))
> > + spin_unlock(&old_base->lock);
> > + )
>
> Like here..... SMP dependent ifdef's of spinlock usage... shudder
>
Well it does seem like a waste to do spinlock ordering code
on a UP system... 

-- 
George Anzinger   george@mvista.com
High-res-timers: 
http://sourceforge.net/projects/high-res-timers/
Preemption patch:
http://www.kernel.org/pub/linux/kernel/people/rml
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sun Dec 15 2002 - 22:00:14 EST