On Mon, 2002-12-30 at 21:03, Linus Torvalds wrote:
> On 30 Dec 2002, Benjamin Herrenschmidt wrote:
> >
> > In current bk 2.5, drivers/video/console/fonts.c exports an
> > init_module() symbol when built-in, which prevents the kernel from
> > linking. Here's a quick fix.
>
> This is not correct.
>
> The functions should either be removed completely (preferred, since they
> aren't even proper C syntax in the first place - since when do we put
> semicolons at the end of a function?) or the file should be taught to use
> proper "module_init()/module_exit()" semantics that work _correctly_ for
> both modules and built-in.
>
> The patch just hides just _how_ crap this file is, and as such should not
> be applied. Crap doesn't get better from being hidden.
Right, though weren't those empty functions just workarounds for a time
where new module stuff didn't grok modules without module init/exit ? Is
this still the case ? If not, then we should indeed just remove the
function completely.
Ben.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Dec 31 2002 - 22:00:17 EST