Re: [PATCH] Deprecate exec_usermodehelper, fix request_module.

From: Andrew Morton (akpm@digeo.com)
Date: Fri Jan 03 2003 - 02:36:57 EST


Brad Hards wrote:
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Fri, 3 Jan 2003 16:08, Rusty Russell wrote:
> > + * Must be called from process context. Returns a negative error code
> > + * if program was not execed successfully, or (exitcode << 8 + signal)
> > + * of the application (0 if wait is not set).
> Any chance that you can remove this (existing) restriction. It'd be good to be
> able to use this in some networking code (eg netif_carrier_[off|on]() ), but
> that might be in interrupt context.
>
> It may be just a matter of duplicating the arguments, but I really know SFA
> about this stuff, and am loath to touch it least it turn to mush in my
> fingers.
>

I vaguely seem to recall having done that once.

It wasn't very pretty:

        int gfp_flags = in_interrupt() ? GFP_ATOMIC : GFP_KERNEL;

Patch against 2.4.0-test13 is at http://www.zip.com.au/~akpm/linux/1.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jan 07 2003 - 22:00:20 EST