[PATCH] make vm_enough_memory more efficient

From: Martin J. Bligh (mbligh@aracnet.com)
Date: Thu Jan 16 2003 - 02:47:04 EST


vm_enough_memory seems to call si_meminfo just to get the total
RAM, which seems far too expensive. This replaces the comment
saying "this is crap" with some code that's less crap.

Not heavily tested (compiles and boots), but seems pretty obvious.

M.

diff -urpN -X /home/fletch/.diff.exclude virgin/mm/mmap.c vm_enough_memory/mm/mmap.c
--- virgin/mm/mmap.c Mon Jan 13 21:09:28 2003
+++ vm_enough_memory/mm/mmap.c Wed Jan 15 23:41:39 2003
@@ -72,7 +72,6 @@ inline void vm_unacct_memory(long pages)
 int vm_enough_memory(long pages)
 {
         unsigned long free, allowed;
- struct sysinfo i;
 
         atomic_add(pages, &vm_committed_space);
 
@@ -113,12 +112,7 @@ int vm_enough_memory(long pages)
                 return 0;
         }
 
- /*
- * FIXME: need to add arch hooks to get the bits we need
- * without this higher overhead crap
- */
- si_meminfo(&i);
- allowed = i.totalram * sysctl_overcommit_ratio / 100;
+ allowed = totalram_pages * sysctl_overcommit_ratio / 100;
         allowed += total_swap_pages;
 
         if (atomic_read(&vm_committed_space) < allowed)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jan 23 2003 - 22:00:12 EST