Re: [PATCH] Proposed module init race fix.

From: Roman Zippel (
Date: Fri Jan 17 2003 - 10:35:22 EST


(I take it as a good sign that I'm not in your .procmailrc yet. :-) )

Rusty Russell wrote:

> > > disk->flags |= GENHD_FL_UP;
> > > blk_register_region(MKDEV(disk->major, disk->first_minor), disk->minors,
> > > NULL, exact_match, exact_lock, disk);
> >
> > blk_register_region() allocates memory, which can fail?
> Looks like. But the semantics are the same as before, for better or worse. 8(

This means add_disk() can fail and according to your rules it can only
be called once. If add_disk() would called a second time, the module
would be live and add_disk() were not allowed to fail anymore.

bye, Roman

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Thu Jan 23 2003 - 22:00:17 EST