EDD bug find: wrong #define is used to declare edd[] area.

From: Kevin Lawton (kevinlawton2001@yahoo.com)
Date: Mon Jan 20 2003 - 19:44:41 EST

It appears to me that the wrong #define is being used to declare the
size of the EDD (BIOS Enhanced Disk Drive Services) area of the setup
parameter page. The following lines use 'EDDNR', but I believe they
meant to use 'EDDMAXNR': (src @ 2.5.59)

  include/asm-i386/edd.h:line 168:

    extern struct edd_info edd[EDDNR];

  arch/i386/kernel/setup.c:line 477:

    struct edd_info edd[EDDNR];

For reference:

  #define EDDNR 0x1e9 /* addr of number of edd_info structs at EDDBUF
  #define EDDMAXNR 6 /* number of edd_info structs starting at

EDDNR is the offset in the parameter page, not the number of entries.
EDDMAXNR seems to be the literal to use. I haven't tried this fix,
because I don't use it. Just noticed it while digging through the source.

-Kevin Lawton

Do you Yahoo!?
New DSL Internet Access from SBC & Yahoo!
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Thu Jan 23 2003 - 22:00:25 EST