Re: [PATCH][2.5] hangcheck-timer

From: Joel Becker (
Date: Tue Jan 21 2003 - 12:33:04 EST

On Tue, Jan 21, 2003 at 08:11:58AM +0000, Christoph Hellwig wrote:
> I can't your see the driver reference CONFIG_* directly anywhere.

        I don't, but I swear something needed it somewhere. I'll look into
removing it.

> > +static int hangcheck_tick = DEFAULT_IOFENCE_TICK;
> > +static int hangcheck_margin = DEFAULT_IOFENCE_MARGIN;
> > +static int hangcheck_reboot = 0; /* Do not reboot */
> no need to initialize static variables to zero, they'll just go into .bss.

        No need, but it is good to explicity mention that the default is
not to reboot.

> It might be worth using Rusty's new module paramters for new code submitted
> to 2.5 instead of the legacy interfaces.

        I guess I should. I'm still encountering the fact that the
module loader in 2.5.59 has issues.

> #if DEBUG maybe? or VERBOSE?

        Probably just to remove. Missed it.



One look at the From: understanding has blossomed .procmailrc grows - Alexander Viro

Joel Becker Senior Member of Technical Staff Oracle Corporation E-mail: Phone: (650) 506-8127 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to More majordomo info at Please read the FAQ at

This archive was generated by hypermail 2b29 : Thu Jan 23 2003 - 22:00:27 EST