Re: common RODATA in vmlinux.lds.h (2.5.59)

From: Greg Ungerer (gerg@snapgear.com)
Date: Tue Jan 21 2003 - 23:47:20 EST


Hiya Miles,

Miles Bader wrote:
> Yeah, the new generic RODATA stuff is way broken on the v850 too.
>
> Besides the over-eager use of sections, it also assumes that C symbol
> names map one-to-one with `linker symbol' names, which isn't true with
> the default v850 compiler.
>
> Here's my local rewrite of include/asm-generic/vmlinux.lds.h, which
> works on the v850, and seems like it should be usable by other systems
> as well.
>
> It does two things:
[snip]
>
> What do you think of this?

I like it. Looks like an ideal solution, keeps a bunch of
stuff common, but is a lot more flexible in terms of output
sections (and their regions) .

> [To be honest, I think the stuff with `LOAD_OFFSET' is a bit of a waste;
> it seems cleaner to just have archs define their own sections as
> appropriate, and use RODATA_CONTENTS directly -- it's the input sections
> and related symbols that are always changing (and so better centralized),
> after all, not the output sections.]

Agree 100%.

Regards
Greg

------------------------------------------------------------------------
Greg Ungerer -- Chief Software Wizard EMAIL: gerg@snapgear.com
SnapGear Pty Ltd PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: www.SnapGear.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jan 23 2003 - 22:00:28 EST