Re: Can't burn DVD under 2.5.59 with ide-cd

From: Jens Axboe (axboe@suse.de)
Date: Thu Jan 23 2003 - 13:10:02 EST


On Thu, Jan 23 2003, Jens Axboe wrote:
> On Thu, Jan 23 2003, Gregoire Favre wrote:
> > On Thu, Jan 23, 2003 at 06:52:24PM +0100, Joerg Schilling wrote:
> >
> > > In one of my mails, I decribed why there are 2 bugs in the kernel.
> > > Only one of them so far has been fixed. The sense data is still missing.
> >
> > Oups, sorry I didn't read enough carefully!!!
> >
> > Does someone know how to fix the sense data bug?
>
> In drivers/ide/ide-cd.c:cdrom_end_request(), try to insert something
> ala:
>
> if ((rq->flags & REQ_SENSE) && uptodate) {
> struct request *failed = (struct request *) rq->buffer;
> struct cdrom_info *info = drive->driver_data;
> void *sense = &info->sense_data;
>
> + if (failed && block_pc_request(failed))
> + printk("%s: failed %p\n", __FUNCTION__, failed->sense);
>
> if (failed && failed->sense)
> sense = failed->sense;
>
> cdrom_analyze_sense_data(drive, failed, sense);
> }
>
> in pseudo-patch form.

oh, and dump failed->sense_len as well!

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jan 23 2003 - 22:00:32 EST