Re: [patch 2.5] tg3.c: pci_{save,restore}_extended_state

From: David S. Miller (davem@redhat.com)
Date: Fri Jan 24 2003 - 16:34:34 EST


   From: "Wiedemeier, Jeff" <Jeff.Wiedemeier@hp.com>
   Date: Fri, 24 Jan 2003 16:33:41 -0500
   
   If it needs to be made a driver decision, there needs to be some way to
   communicate the correct vector information for whichever option the
   driver is using (if there already is and I missed it, please let me
   know). Otherwise, it seems that trying to match spec behavior given the
   hardware design or disabling MSI at config time for these devices (such
   as through quirks) are the options.

Right, the whole issue is that we're generally MSI ignorant in our PCI
layer right now. And you're trying to make use of MSI on some
platform :-)

So because the driver has no way to ask the platform "are you going
to use MSI for this device?" there is no way for tg3 to portably
deal with this issue.

That being said, why don't we add "pci_using_msi(pdev)" to asm/pci.h?
Once we have that, tg3.c can then go and set the tg3 specific MSI
enable bit to match whatever pci_using_msi(pdev) returns. This, plus
the extended state save/restore, should solve all the problems.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jan 31 2003 - 22:00:13 EST