Re: Solved 2.4.21-pre3aa1 and RAID-0 issue (was: Re: 2.4.21-pre3aa1 and RAID0 issue]

From: Jens Axboe (axboe@suse.de)
Date: Mon Jan 27 2003 - 06:30:02 EST


On Mon, Jan 27 2003, Srihari Vijayaraghavan wrote:
> Hello Andrea,
>
> On Thursday 23 January 2003 01:02, Srihari Vijayaraghavan wrote:
> > ...
> > Ok. I did some more testing, and this is what happens:
> > /sbin/raidstart /dev/md0 executes and exits fine under 2.4.21-pre3. Where
> > as under 2.4.21-pre3aa1 it starts executing but _never_ exits (I waited for
> > few minutes). I had to kill it using alt + sysrq + k.
> > ...
>
> The 9985_blk-atomic-aa5 patch is causing this regression. Backing this patch
> out of 2.4.21-pre3aa1 makes it to work nicely with Software RAID-0.

Could you please try this patch on top of 2.4.21-pre3aa1 instead of
backing out blk-atomic? Does that work, too? Thanks!

===== drivers/md/md.c 1.38 vs edited =====
--- 1.38/drivers/md/md.c Thu Jan 16 00:15:01 2003
+++ edited/drivers/md/md.c Mon Jan 27 12:23:41 2003
@@ -494,6 +494,7 @@
         bh.b_page = page;
         bh.b_reqnext = NULL;
         bh.b_data = page_address(page);
+ bh.b_elv_sequence = 0;
         generic_make_request(rw, &bh);
 
         run_task_queue(&tq_disk);
===== drivers/md/raid1.c 1.15 vs edited =====
--- 1.15/drivers/md/raid1.c Sat Aug 31 02:20:48 2002
+++ edited/drivers/md/raid1.c Mon Jan 27 12:27:44 2003
@@ -686,6 +686,7 @@
                  mbh->b_list = BUF_LOCKED;
                  mbh->b_end_io = raid1_end_request;
                  mbh->b_private = r1_bh;
+ mbh->b_elv_sequence = bh->b_elv_sequence;
 
                 mbh->b_next = r1_bh->mirror_bh_list;
                 r1_bh->mirror_bh_list = mbh;
@@ -1456,6 +1457,7 @@
         bh->b_private = r1_bh;
         bh->b_blocknr = sector_nr;
         bh->b_rsector = sector_nr;
+ bh->b_elv_sequence = 0;
         init_waitqueue_head(&bh->b_wait);
 
         generic_make_request(READ, bh);

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jan 31 2003 - 22:00:16 EST