Re: Linux 2.4.21pre4-ac1

From: Adrian Bunk (bunk@fs.tum.de)
Date: Fri Jan 31 2003 - 15:21:06 EST


On Fri, Jan 31, 2003 at 09:30:20AM -0500, Alan Cox wrote:

>...
> Linux 2.4.21pre4-ac1
>...
> o Clean up radio_cadet locking and other bugs (me)
>...

This causes the following compile error:

<-- snip -->

...
gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.20-ac/include
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6 -nostdinc
-iwithprefix include -DKBUILD_BASENAME=radio_cadet -c -o radio-cadet.o
radio-cadet.c
radio-cadet.c: In function `cadet_init':
radio-cadet.c:561: `cadet_lock' undeclared (first use in this function)
radio-cadet.c:561: (Each undeclared identifier is reported only once
radio-cadet.c:561: for each function it appears in.)
make[4]: *** [radio-cadet.o] Error 1
make[4]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.20-ac/drivers/media/radio'

<-- snip -->

It seems the following was intended?

--- linux-2.4.20-ac/drivers/media/radio/radio-cadet.c.old 2003-01-31 21:04:17.000000000 +0100
+++ linux-2.4.20-ac/drivers/media/radio/radio-cadet.c 2003-01-31 21:04:34.000000000 +0100
@@ -558,7 +558,7 @@
 static int __init cadet_init(void)
 {
 
- spin_lock_init(&cadet_lock);
+ spin_lock_init(&cadet_io_lock);
         
         /*
          * If a probe was requested then probe ISAPnP first (safest)

cu
Adrian

-- 

"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jan 31 2003 - 22:00:26 EST