Re: [PATCH][RFC] Resource Management Improvements (1/4)

From: Jaroslav Kysela (perex@perex.cz)
Date: Mon Feb 03 2003 - 04:44:12 EST


On Sun, 2 Feb 2003, Adam Belay wrote:

> This patch is the first of 4 experimental pnp patches. It is against a clean
> 2.5.59 kernel. I would appreciate for those who are interested, if you would
> test this patch series and post your results on lkml. These changes appear
> to be very stable on my test systems and I feel they will be a dramatic
> improvement to the pnp layer.
>
> Patch 1 contains resource management improvements that will allow the pnp
> layer to resolve virtually any resource conflict. A new kernel parameter
> "pnp_max_moves=" was added to allow the user to describe the maximum number
> of device levels to move during conflict resolution. This powerful new
> engine also includes many cleanups and more verbose reporting. All devices
> are configured when added instead of when activated. This will increase
> the odds that the conflict will be possible to resolve because resources
> cannot be moved in an active device.

I don't agree with this. Simply, why to activate devices which will not be
ever used? You'll occupy resources which can be assigned to another
device. Also, you simply removed my configuration templates, so the driver
cannot tell explicitly which resources PnP layer should assign. Also
activation (and resource allocation) should be on request allowing driver
to do things manually. Bad bad bad. We're again in state a month ago when
nothing worked and ALSA ISA PnP drivers are still broken, because your
model doesn't have all features like good old ISA PnP code. Also, with all
respects, I think that you're trying to write very clever code. It's also
bad. It will end with numerous problems and with undeterministic behaviour
like unnamed commercial OS. Let users to pass their own configurations.

                                                Jaroslav

-----
Jaroslav Kysela <perex@suse.cz>
Linux Kernel Sound Maintainer
ALSA Project, SuSE Labs

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 07 2003 - 22:00:10 EST