re: smctr patch (with no subect)

• Next message: Rusty Russell: "Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c"
• Previous message: Rusty Russell: "Re: [PATCH] 2.5.59 : sound/oss/vidc.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

In message <Pine.LNX.4.44.0302071204270.6917-100000@master> you write:
> Hello all,
> The following patch addresses buzilla bug # 312, and removes an
> offending semicolon. Please review for inclusion.
>
> Regards,
> Frank
>
> --- linux/drivers/net/tokenring/smctr.c.old 2003-01-16 21:22:09.000000000 -
0500
> +++ linux/drivers/net/tokenring/smctr.c 2003-02-07 03:10:50.000000000 -
0500
> @@ -3064,7 +3064,7 @@
> __u8 r;
>
> /* Check if node address has been specified by user. (non-0) */
> - for(i = 0; ((i < 6) && (dev->dev_addr[i] == 0)); i++);
> + for(i = 0; ((i < 6) && (dev->dev_addr[i] == 0)); i++)
> {
> if(i != 6)
> {

NAK, I believe this is the way the code is supposed to work.

Of course, opening a new block after the for is completely gratuitous
and designed to fool the reader.

Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Rusty Russell: "Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c"
• Previous message: Rusty Russell: "Re: [PATCH] 2.5.59 : sound/oss/vidc.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Feb 15 2003 - 22:00:24 EST