Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c

• Next message: Andrea Arcangeli: "Re: stochastic fair queueing in the elevator [Re: [BENCHMARK] 2.4.20-ck3 / aa / rmap with contest]"
• Previous message: Kevin Curtis: "Anything change in /proc file system in 2.2.22"
• In reply to: Rusty Russell: "Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Rusty Russell <rusty@rustcorp.com.au> said:
> In message <Pine.LNX.4.44.0302071217520.6917-100000@master> you write:
> > --- linux/drivers/char/ite_gpio.c.old 2003-01-16 21:22:23.000000000 -0500
> > +++ linux/drivers/char/ite_gpio.c 2003-02-07 02:04:43.000000000 -0500
> > @@ -140,7 +140,7 @@
> > {
> > int ret=-1;
> >
> > - if (MAX_GPIO_LINE > *data >= 0)
> > + if ((MAX_GPIO_LINE > *data) && (*data >= 0))
> > ret=ite_gpio_irq_pending[*data];
> >
> > DEB(printk("ite_gpio_in_status %d ret=%d\n",*data, ret));
>
> Nope, of course *data is >= 0, it's a u32.

MAX_GPIO_LINE > *data >= 0 is (MAX_GPIO_LINE > *data) >= 0 is (0 or 1) >= 0
is 1 ;-)

-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                     Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria              +56 32 654239
Casilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Andrea Arcangeli: "Re: stochastic fair queueing in the elevator [Re: [BENCHMARK] 2.4.20-ck3 / aa / rmap with contest]"
• Previous message: Kevin Curtis: "Anything change in /proc file system in 2.2.22"
• In reply to: Rusty Russell: "Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Feb 15 2003 - 22:00:26 EST